linux-kernel - Re: [PATCH] MIPS: Use proper @return keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9bd8b13f-e9c0-44ec-f53d-f9171973d9a8@infradead.org>
Date:   Tue, 26 Dec 2017 08:29:16 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     Ralf Baechle <ralf@...ux-mips.org>,
        "Maciej W. Rozycki" <macro@...s.com>,
        Paul Burton <paul.burton@...s.com>,
        Ingo Molnar <mingo@...nel.org>, linux-mips@...ux-mips.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: Use proper @return keyword

On 12/26/2017 02:55 AM, Mathieu Malaterre wrote:
> Fix non-fatal warning:
> 
> arch/mips/kernel/branch.c:418: warning: Excess function parameter 'returns' description in '__compute_return_epc_for_insn'
> 
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> ---
>  arch/mips/kernel/branch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/kernel/branch.c b/arch/mips/kernel/branch.c
> index b79ed9af9886..e0d3a432e1e3 100644
> --- a/arch/mips/kernel/branch.c
> +++ b/arch/mips/kernel/branch.c
> @@ -399,7 +399,7 @@ int __MIPS16e_compute_return_epc(struct pt_regs *regs)
>   *
>   * @regs:	Pointer to pt_regs
>   * @insn:	branch instruction to decode
> - * @returns:	-EFAULT on error and forces SIGILL, and on success
> + * @return:	-EFAULT on error and forces SIGILL, and on success

No @, just
	return: <text>

>   *		returns 0 or BRANCH_LIKELY_TAKEN as appropriate after
>   *		evaluating the branch.
>   *
> 


-- 
~Randy