linux-kernel - RE: [PATCH 1/2] MIPS: math-emu: Do not export function `srl128`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BD3A5F1946F2E540A31AF2CE969BAEEEC28277@MIPSMAIL01.mipstec.com>
Date:   Tue, 26 Dec 2017 18:10:30 +0000
From:   Aleksandar Markovic <Aleksandar.Markovic@...s.com>
To:     Mathieu Malaterre <malat@...ian.org>
CC:     Ralf Baechle <ralf@...ux-mips.org>,
        Miodrag Dinic <Miodrag.Dinic@...s.com>,
        Goran Ferenc <goran.ferenc@...tec.com>,
        James Hogan <jhogan@...nel.org>,
        Douglas Leung <douglas.leung@...tec.com>,
        "linux-mips@...ux-mips.org" <linux-mips@...ux-mips.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2] MIPS: math-emu: Do not export function `srl128`

> > Fix non-fatal warning:
> >
> > arch/mips/math-emu/dp_maddf.c:19:6: warning: no previous prototype for ‘srl128’ [-Wmissing-prototypes]
> >  void srl128(u64 *hptr, u64 *lptr, int count)
> >
> > Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> > ---
> >  arch/mips/math-emu/dp_maddf.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/mips/math-emu/dp_maddf.c b/arch/mips/math-emu/dp_maddf.c
> > index 7ad79ed411f5..0e2278a47f43 100644
> > --- a/arch/mips/math-emu/dp_maddf.c
> > +++ b/arch/mips/math-emu/dp_maddf.c
> > @@ -16,7 +16,7 @@
> >
> >
> >  /* 128 bits shift right logical with rounding. */
> > -void srl128(u64 *hptr, u64 *lptr, int count)
> > +static void srl128(u64 *hptr, u64 *lptr, int count)
> >  {
> >          u64 low;
> >
> > --
> > 2.11.0
> 
> Acked-by: Aleksandar Markovic <aleksandar.markovic@...s.com>

However, there is an already submitted patch: (the code change is identical)

https://www.linux-mips.org/archives/linux-mips/2017-11/msg00044.html

Status of that patch on patchwork is "Accepted".

Regards,
Aleksandar