lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <B5AD6AAA-970B-468B-8897-E2B161F5AFED@holtmann.org> Date: Tue, 26 Dec 2017 22:00:22 +0100 From: Marcel Holtmann <marcel@...tmann.org> To: Kai-Heng Feng <kai.heng.feng@...onical.com> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-usb@...r.kernel.org, "open list:BLUETOOTH DRIVERS" <linux-bluetooth@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, stable <stable@...r.kernel.org>, Leif Liddy <leif.linux@...il.com>, Matthias Kaehlcke <mka@...omium.org>, Brian Norris <briannorris@...omium.org>, Daniel Drake <drake@...lessm.com> Subject: Re: [PATCH 1/2] Revert "Bluetooth: btusb: fix QCA Rome suspend/resume" Hi Kai-Heng, > This reverts commit fd865802c66bc451dc515ed89360f84376ce1a56. > > This commit causes a regression on some QCA ROME chips. The USB device > reset happens in btusb_open(), hence firmware loading gets interrupted. > > Furthermore, this commit stops working after commit > ("a0085f2510e8976614ad8f766b209448b385492f Bluetooth: btusb: driver to > enable the usb-wakeup feature"). Reset-resume quirk only gets enabled in > btusb_suspend() when it's not a wakeup source. > > If we really want to reset the USB device, we need to do it before > btusb_open(). Let's handle it in drivers/usb/core/quirks.c. > > Cc: stable@...r.kernel.org > Cc: Leif Liddy <leif.linux@...il.com> > Cc: Matthias Kaehlcke <mka@...omium.org> > Cc: Brian Norris <briannorris@...omium.org> > Cc: Daniel Drake <drake@...lessm.com> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com> > > --- > > Daniel, Cc you because this also affects your original quirk patch for > Realtek btusb. > > drivers/bluetooth/btusb.c | 6 ------ > 1 file changed, 6 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel
Powered by blists - more mailing lists