lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20171226084713.GA2175@nanopsycho> Date: Tue, 26 Dec 2017 09:47:13 +0100 From: Jiri Pirko <jiri@...lanox.com> To: Florian Fainelli <f.fainelli@...il.com> Cc: Oleksandr Shamray <oleksandrs@...lanox.com>, gregkh@...uxfoundation.org, arnd@...db.de, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, openbmc@...ts.ozlabs.org, joel@....id.au, jiri@...nulli.us, tklauser@...tanz.ch, linux-serial@...r.kernel.org, vadimp@...lanox.com, system-sw-low-level@...lanox.com, robh+dt@...nel.org, openocd-devel-owner@...ts.sourceforge.net, linux-api@...r.kernel.org, davem@...emloft.net, mchehab@...nel.org Subject: Re: [patch v15 1/4] drivers: jtag: Add JTAG core driver Tue, Dec 26, 2017 at 12:09:08AM CET, f.fainelli@...il.com wrote: >Le 12/25/17 à 03:53, Oleksandr Shamray a écrit : [...] >[snip] > >> + >> +void *jtag_priv(struct jtag *jtag) >> +{ >> + return jtag->priv; >> +} >> +EXPORT_SYMBOL_GPL(jtag_priv); > >Can't you just create a static inline function in the public header for >that? This is usually what subsystems do, I can understand why you would >not want to expose struct jtag to other parts of the kernel, but still, >this looks ugly, so maybe consider splitting the header between provider >and consumer? Other subsystems expose the struct. Here, it is intentional to don't expose the struct, that's why we have this helper. What is ugly about that? :)
Powered by blists - more mailing lists