linux-kernel - RE: [PATCH 2/2 v4] scsi: ufs: introduce sysfs entries exposing UFS health info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM5PR04MB10856CCEE145B2B8AADDF668FC070@DM5PR04MB1085.namprd04.prod.outlook.com>
Date:   Wed, 27 Dec 2017 09:00:10 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jaegeuk Kim <jaegeuk@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        Jaegeuk Kim <jaegeuk@...gle.com>,
        Alex Lemberg <Alex.Lemberg@....com>,
        Stanislav Nijnikov <Stanislav.Nijnikov@....com>
Subject: RE: [PATCH 2/2 v4] scsi: ufs: introduce sysfs entries exposing UFS
 health info



> -----Original Message-----
> From: linux-scsi-owner@...r.kernel.org [mailto:linux-scsi-
> owner@...r.kernel.org] On Behalf Of Greg Kroah-Hartman
> Sent: Thursday, December 21, 2017 10:00 AM
> To: Jaegeuk Kim <jaegeuk@...nel.org>
> Cc: linux-kernel@...r.kernel.org; linux-scsi@...r.kernel.org; Jaegeuk Kim
> <jaegeuk@...gle.com>
> Subject: Re: [PATCH 2/2 v4] scsi: ufs: introduce sysfs entries exposing UFS
> health info
> 
> On Wed, Dec 20, 2017 at 02:13:25PM -0800, Jaegeuk Kim wrote:
> > This patch adds a new sysfs group, namely health, via:
> >
> >    /sys/devices/soc/X.ufshc/health/
As device health is just one piece of information out of the device management,
I think that you should address this in a more comprehensive way,
And set hooks for much more device info:
Allow access to device descriptors, attributes and flags.
The attributes and flags should be placed in separate subfolders
The LUN specific descriptors and attributes should be placed in a luns subfolder, and then per descriptor / attribute type
You might also would like to consider differentiating read and write - to control those type of accesses as well.

Cheers,
Avri