linux-kernel - Re: [PATCH] clk: mediatek: remove unnecessary include header from reset.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171227011021.GQ7997@codeaurora.org>
Date:   Tue, 26 Dec 2017 17:10:21 -0800
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     sean.wang@...iatek.com
Cc:     mturquette@...libre.com, matthias.bgg@...il.com, jdelvare@...e.de,
        jamesjj.liao@...iatek.com, weiyi.lu@...iatek.com, arnd@...db.de,
        linux-mediatek@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: mediatek: remove unnecessary include header from
 reset.c

On 12/25, sean.wang@...iatek.com wrote:
> From: Sean Wang <sean.wang@...iatek.com>
> 
> In fact, the clk-mtk.h header is indeed not needed for reset.c and thus
> it's safe and good change to remove it from the file.
> 
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
> Reviewed-by: Jean Delvare <jdelvare@...e.de>
> Cc: Jean Delvare <jdelvare@...e.de>
> ---
>  drivers/clk/mediatek/reset.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/clk/mediatek/reset.c b/drivers/clk/mediatek/reset.c
> index d3551d5..70ebb2e 100644
> --- a/drivers/clk/mediatek/reset.c
> +++ b/drivers/clk/mediatek/reset.c
> @@ -19,8 +19,6 @@
>  #include <linux/reset-controller.h>
>  #include <linux/slab.h>
>  
> -#include "clk-mtk.h"
> -

drivers/clk/mediatek/reset.c:64:6: warning: symbol 'mtk_register_reset_controller' was not declared. Should it be static?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project