linux-kernel - Re: [v3,21/27] watchdog: replace devm_ioremap_nocache with devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30d0f7f4-8f93-de23-83b7-72a9c8d4a47f@huawei.com>
Date:   Wed, 27 Dec 2017 17:36:01 +0800
From:   Yisheng Xie <xieyisheng1@...wei.com>
To:     Guenter Roeck <linux@...ck-us.net>
CC:     <linux-kernel@...r.kernel.org>, <gregkh@...uxfoundation.org>,
        <ysxie@...mail.com>, Wim Van Sebroeck <wim@...ana.be>,
        <linux-watchdog@...r.kernel.org>
Subject: Re: [v3,21/27] watchdog: replace devm_ioremap_nocache with
 devm_ioremap

Hi Guenter,

On 2017/12/27 1:28, Guenter Roeck wrote:
> On Sat, Dec 23, 2017 at 07:01:37PM +0800, Yisheng Xie wrote:
>> > Default ioremap is ioremap_nocache, so devm_ioremap has the same
>> > function with devm_ioremap_nocache, which can just be killed to
>> > save the size of devres.o
>> > 
>> > This patch is to use use devm_ioremap instead of devm_ioremap_nocache,
>> > which should not have any function change but prepare for killing
>> > devm_ioremap_nocache.
>> > 
> I don't have issues with the patch itself - on mips, the definitions
> _are_ the same - but with the description. It is not universally correct
> that the definitions are the same. Please update and resubmit.
> 

Right, there are 4 archs have different meaning of ioremap. And presently, I
still do not know why.

For this patch itself, maybe I can update and resubmit.

Thanks and Merry Christmas.
Yisheng

> Guenter
>