lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <798460c2d6ed47dcb85c9540829a5ef8@euamsexm01a.eu.qualcomm.com> Date: Wed, 27 Dec 2017 11:04:43 +0100 From: Kalle Valo <kvalo@....qualcomm.com> To: Arnd Bergmann <arnd@...db.de> Cc: Maya Erez <qca_merez@....qualcomm.com>, Kalle Valo <kvalo@...eaurora.org>, Arnd Bergmann <arnd@...db.de>, Lazar Alexei <QCA_ailizaro@....qualcomm.com>, Dedy Lansky <qca_dlansky@...lcomm.com>, Hamad Kadmany <QCA_hkadmany@....qualcomm.com>, Lior David <qca_liord@....qualcomm.com>, Gidon Studinski <QCA_gidons@....qualcomm.com>, <linux-wireless@...r.kernel.org>, <wil6210@....qualcomm.com>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: wil6210: fix build warnings without CONFIG_PM Arnd Bergmann <arnd@...db.de> wrote: > The #ifdef checks are hard to get right, in this case some functions > should have been left inside a CONFIG_PM_SLEEP check as seen by this > message: > > drivers/net/wireless/ath/wil6210/pcie_bus.c:489:12: error: 'wil6210_pm_resume' defined but not used [-Werror=unused-function] > drivers/net/wireless/ath/wil6210/pcie_bus.c:484:12: error: 'wil6210_pm_suspend' defined but not used [-Werror=unused-function] > > Using an __maybe_unused is easier here, so I'm replacing all the > other #ifdef in this file as well for consistency. > > Fixes: 94162666cd51 ("wil6210: run-time PM when interface down") > Signed-off-by: Arnd Bergmann <arnd@...db.de> > Signed-off-by: Kalle Valo <kvalo@....qualcomm.com> Patch applied to ath-next branch of ath.git, thanks. 203dab8395d9 wil6210: fix build warnings without CONFIG_PM -- https://patchwork.kernel.org/patch/10119565/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists