lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5A437DED.3030703@gmail.com>
Date:   Wed, 27 Dec 2017 16:33:09 +0530
From:   arvindY <arvind.yadav.cs@...il.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     nsekhar@...com, khilman@...nel.org, linux@...linux.org.uk,
        kaloz@...nwrt.org, khalasa@...p.pl, aaro.koskinen@....fi,
        tony@...mide.com, jason@...edaemon.net, andrew@...n.ch,
        sebastian.hesselbarth@...il.com,
        gregory.clement@...e-electrons.com, daniel@...que.org,
        haojian.zhuang@...il.com, marek.vasut@...il.com,
        slapin@...fans.org, jic23@....ac.uk, kgene@...nel.org,
        ralf@...ux-mips.org, ysato@...rs.sourceforge.jp, dalias@...c.org,
        tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 10/11 v3] ARM: s3c24xx/s3c64xx: constify gpio_led

Hi,

On Wednesday 27 December 2017 01:49 PM, Krzysztof Kozlowski wrote:
> On Tue, Dec 26, 2017 at 7:50 PM, Arvind Yadav <arvind.yadav.cs@...il.com> wrote:
>> gpio_led are not supposed to change at runtime.
>> struct gpio_led_platform_data working with const gpio_led
>> provided by <linux/leds.h>. So mark the non-const structs
>> as const.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
>> ---
>> changes in v2:
>>                The GPIO LED driver can be built as a module, it can
>>                be loaded after the init sections have gone away.
>>                So removed '__initconst'.
>> changes in v3:
>>               Description was missing.
>>
>>   arch/arm/mach-s3c24xx/mach-h1940.c    | 2 +-
>>   arch/arm/mach-s3c24xx/mach-rx1950.c   | 2 +-
>>   arch/arm/mach-s3c64xx/mach-hmt.c      | 2 +-
>>   arch/arm/mach-s3c64xx/mach-smartq5.c  | 2 +-
>>   arch/arm/mach-s3c64xx/mach-smartq7.c  | 2 +-
>>   arch/arm/mach-s3c64xx/mach-smdk6410.c | 2 +-
>>   6 files changed, 6 insertions(+), 6 deletions(-)
> There were few build errors reported by kbuild for your patches. Are
> you sure that you compiled every file you touch?
>
> Best regards,
> Krzysztof
Yes, I got few build error which I have fixed it. and send updated patch.
Now I have done cross checking.  It's not having any build failure.

Regards
arvind

Powered by blists - more mailing lists