lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAH7mPvh0=Hzo=UZnUW4_W1J6aLP--r2byZbgE5EKziHRadhm+A@mail.gmail.com> Date: Tue, 26 Dec 2017 19:35:12 -0500 From: Nick Desaulniers <nick.desaulniers@...il.com> To: Josh Poimboeuf <jpoimboe@...hat.com> Cc: Ingo Molnar <mingo@...nel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Lukas Bulwahn <lukas.bulwahn@...il.com>, Jiri Slaby <jslaby@...e.cz> Subject: Re: [PATCH] objtool: Fix clang enum conversion warning I sent a similar one recently: https://patchwork.kernel.org/patch/10131815/ (maybe Josh is just forwarding me an earlier fix?) Reviewed-by: Nick Desaulniers <nick.desaulniers@...il.com> On Tue, Dec 26, 2017 at 4:27 PM, Josh Poimboeuf <jpoimboe@...hat.com> wrote: > From: Lukas Bulwahn <lukas.bulwahn@...il.com> > > Fix the following clang enum conversion warning: > > arch/x86/decode.c:141:20: error: implicit conversion from enumeration > type 'enum op_src_type' to different enumeration > type 'enum op_dest_type' [-Werror,-Wenum-conversion] > > op->dest.type = OP_SRC_REG; > ~ ^~~~~~~~~~ > > It just happened to work before because OP_SRC_REG and OP_DEST_REG have > the same value. > > Fixes: baa41469a7b9 ("objtool: Implement stack validation 2.0") > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com> > Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com> > --- > tools/objtool/arch/x86/decode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/objtool/arch/x86/decode.c b/tools/objtool/arch/x86/decode.c > index 8acfc47af70e..540a209b78ab 100644 > --- a/tools/objtool/arch/x86/decode.c > +++ b/tools/objtool/arch/x86/decode.c > @@ -138,7 +138,7 @@ int arch_decode_instruction(struct elf *elf, struct section *sec, > *type = INSN_STACK; > op->src.type = OP_SRC_ADD; > op->src.reg = op_to_cfi_reg[modrm_reg][rex_r]; > - op->dest.type = OP_SRC_REG; > + op->dest.type = OP_DEST_REG; > op->dest.reg = CFI_SP; > } > break; > -- > 2.13.6 >
Powered by blists - more mailing lists