lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c668b55b-f35e-cdfd-1f90-dc1289a73b40@nokia.com>
Date:   Wed, 27 Dec 2017 15:46:37 +0100
From:   Romain Porte <romain.porte@...ia.com>
To:     cyrille.pitchen@...ev4u.fr
Cc:     linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        alexander.sverdlin@...ia.com, pascal.fabreges@...ia.com
Subject: Re: [PATCH v2] mtd: spi-nor: Added ISSI is25lp080d support

On 27/12/2017 14:58, Romain Porte wrote:
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 8bafd462f..18e826d36 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1050,6 +1050,8 @@ static const struct flash_info spi_nor_ids[] = {
>   			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>   	{ "is25lp128",  INFO(0x9d6018, 0, 64 * 1024, 256,
>   			SECT_4K | SPI_NOR_DUAL_READ) },
> +	{ "is25lp080d", INFO(0x9d6014, 0, 64 * 1024,  16,
> +			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>   
Please note that the new SPI_NOR_DUAL_READ and SPI_NOR_QUAD_READ options 
have not been tested on our hardware for the moment. The Tested-by flag 
applies only for the previous configuration without these two new flags. 
We may be able to test these additional flags in the future, but they 
were added only from your (Cyrille's) review from previous patch.

Please let me know if you want to wait for our hardware test results 
before merging into spi-nor/next, or if you are confident enough to 
merge it as this.

Romain.

Powered by blists - more mailing lists