lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAL_JsqJwt1FfdiOCRnMSKWmAW668XqGvKsuZqKrXfkNnt3MPRQ@mail.gmail.com> Date: Wed, 27 Dec 2017 11:24:01 -0600 From: Rob Herring <robh+dt@...nel.org> To: Bartosz Golaszewski <brgl@...ev.pl> Cc: Andy Shevchenko <andy.shevchenko@...il.com>, Mark Rutland <mark.rutland@....com>, Javier Martinez Canillas <javier@...hile0.org>, David Lechner <david@...hnology.com>, Divagar Mohandass <divagar.mohandass@...el.com>, Peter Rosin <peda@...ntia.se>, Linux I2C <linux-i2c@...r.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v3 1/5] dt-bindings: at24: consistently document the compatible property On Wed, Dec 27, 2017 at 7:50 AM, Bartosz Golaszewski <brgl@...ev.pl> wrote: > Current description of the compatible property for at24 is quite vague. > > State explicitly that any "<manufacturer>,<model>" pair is accepted as > long as one of the listed strings is used as fallback. > > Signed-off-by: Bartosz Golaszewski <brgl@...ev.pl> > --- > Documentation/devicetree/bindings/eeprom/at24.txt | 37 +++++++++-------------- > 1 file changed, 15 insertions(+), 22 deletions(-) > > diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt > index cbc80e194ac6..b5ce5a247554 100644 > --- a/Documentation/devicetree/bindings/eeprom/at24.txt > +++ b/Documentation/devicetree/bindings/eeprom/at24.txt > @@ -2,28 +2,21 @@ EEPROMs (I2C) > > Required properties: > > - - compatible : should be "<manufacturer>,<type>", like these: > - > - "atmel,24c00", "atmel,24c01", "atmel,24c02", "atmel,24c04", > - "atmel,24c08", "atmel,24c16", "atmel,24c32", "atmel,24c64", > - "atmel,24c128", "atmel,24c256", "atmel,24c512", "atmel,24c1024" > - > - "catalyst,24c32" > - > - "microchip,24c128" > - > - "ramtron,24c64" > - > - "renesas,r1ex24002" > - > - The following manufacturers values have been deprecated: > - "at", "at24" > - > - If there is no specific driver for <manufacturer>, a generic > - device with <type> and manufacturer "atmel" should be used. > - Possible types are: > - "24c00", "24c01", "24c02", "24c04", "24c08", "24c16", "24c32", "24c64", > - "24c128", "24c256", "24c512", "24c1024", "spd" > + - compatible: must be a "<manufacturer>,<model>" pair with one of the Also, why do you add "must" here and then fix it with "Must" in patch 3? Just get it right here. Rob
Powered by blists - more mailing lists