lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20171227211643.nnwtm4j6cyftlm66@kekkonen.localdomain> Date: Wed, 27 Dec 2017 23:16:44 +0200 From: Sakari Ailus <sakari.ailus@...ux.intel.com> To: Pavel Machek <pavel@....cz> Cc: robh+dt@...nel.org, mark.rutland@....com, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, pali.rohar@...il.com, sre@...nel.org, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, linux-omap@...r.kernel.org, tony@...mide.com, khilman@...nel.org, aaro.koskinen@....fi, ivo.g.dimitrov.75@...il.com, patrikbachan@...il.com, serge@...lyn.com, abcloriens@...il.com, clayton@...ftyguy.net, martijn@...xit.nl, Filip Matijević <filip.matijevic.pz@...il.com> Subject: Re: [PATCH] Device tree binding for Avago APDS990X light sensor On Wed, Dec 27, 2017 at 09:01:47PM +0100, Pavel Machek wrote: > Hi! > > > > +Required properties: > > > +- compatible: "avago,apds990x" > > > +- reg: address on the I2C bus > > > +- interrupts: external interrupt line number > > > +- Vdd-supply: power supply for VDD > > > +- Vled-supply: power supply for LEDA > > > > AFAIK the custom is to use lower case letters for regulator supplies. > > > > > +- ga: Glass attenuation > > > +- cf1: Clear channel factor 1 > > > +- irf1: IR channel factor 1 > > > +- cf2: Clear channel factor 2 > > > +- irf2: IR channel factor 2 > > > +- df: Device factor > > > +- pdrive: IR current, one of APDS_IRLED_CURR_XXXmA values > > > +- ppcount: Proximity pulse count > > > > Are these device specific? If so, please add the vendor prefix to them. > > Well, whole binding is "vendor specific". Does it make sense to add > prefix in such case? Yes, it does. If you later find one or more of these are generic, you could remove the vendor prefix. I doubt that'll happen though, these seem very device specific parameters. -- Sakari Ailus sakari.ailus@...ux.intel.com
Powered by blists - more mailing lists