lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1979156.HCZ09VA8ni@aspire.rjw.lan> Date: Wed, 27 Dec 2017 01:44:03 +0100 From: "Rafael J. Wysocki" <rjw@...ysocki.net> To: Jeffy Chen <jeffy.chen@...k-chips.com> Cc: linux-kernel@...r.kernel.org, bhelgaas@...gle.com, linux-pm@...r.kernel.org, tony@...mide.com, shawn.lin@...k-chips.com, briannorris@...omium.org, dianders@...omium.org, Xinming Hu <huxm@...vell.com>, linux-pci@...r.kernel.org, Rob Herring <robh+dt@...nel.org>, Catalin Marinas <catalin.marinas@....com>, Kalle Valo <kvalo@...eaurora.org>, Heiko Stuebner <heiko@...ech.de>, linux-rockchip@...ts.infradead.org, Nishant Sarmukadam <nishants@...vell.com>, Will Deacon <will.deacon@....com>, Matthias Kaehlcke <mka@...omium.org>, devicetree@...r.kernel.org, Ganapathi Bhat <gbhat@...vell.com>, Frank Rowand <frowand.list@...il.com>, Amitkumar Karwar <amitkarwar@...il.com>, linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org, linux-wireless@...r.kernel.org, Klaus Goger <klaus.goger@...obroma-systems.com>, Mark Rutland <mark.rutland@....com> Subject: Re: [RFC PATCH v12 0/5] PCI: rockchip: Move PCIe WAKE# handling into pci core On Tuesday, December 26, 2017 3:36:41 AM CET Jeffy Chen wrote: > > Currently we are handling wake irq in mrvl wifi driver. Move it into > pci core. > > Tested on my chromebook bob(with cros 4.4 kernel and mrvl wifi). > > > Changes in v13: > Fix compiler error reported by kbuild test robot <fengguang.wu@...el.com> > > Changes in v12: > Only add irq definitions for PCI devices and rewrite the commit message. > Enable the wake irq in noirq stage to avoid possible irq storm. > > Changes in v11: > Address Brian's comments. > Only support 1-per-device PCIe WAKE# pin as suggested. > Move to pcie port as Brian suggested. > > Changes in v10: > Use device_set_wakeup_capable() instead of device_set_wakeup_enable(), > since dedicated wakeirq will be lost in device_set_wakeup_enable(false). > > Changes in v9: > Add section for PCI devices and rewrite the commit message. > Fix check error in .cleanup(). > Move dedicated wakeirq setup to setup() callback and use > device_set_wakeup_enable() to enable/disable. > Rewrite the commit message. > > Changes in v8: > Add optional "pci", and rewrite commit message. > Add pci-of.c and use platform_pm_ops to handle the PCIe WAKE# signal. > Rewrite the commit message. > > Changes in v7: > Move PCIE_WAKE handling into pci core. > > Changes in v6: > Fix device_init_wake error handling, and add some comments. > > Changes in v5: > Move to pci.txt > Rebase. > Use "wakeup" instead of "wake" > > Changes in v3: > Fix error handling. > > Changes in v2: > Use dev_pm_set_dedicated_wake_irq. > > Jeffy Chen (5): > dt-bindings: PCI: Add definition of PCIe WAKE# irq and PCI irq > of/irq: Adjust of_pci_irq parsing for multiple interrupts > mwifiex: Disable wakeup irq handling for pcie > PCI / PM: Add support for the PCIe WAKE# signal for OF > arm64: dts: rockchip: Move PCIe WAKE# irq to pcie port for Gru > > Documentation/devicetree/bindings/pci/pci.txt | 10 ++++ > arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 11 ++-- > drivers/net/wireless/marvell/mwifiex/main.c | 4 ++ > drivers/of/of_pci_irq.c | 71 +++++++++++++++++++++++-- > drivers/pci/Makefile | 1 + > drivers/pci/pci-driver.c | 10 ++++ > drivers/pci/pci-of.c | 75 +++++++++++++++++++++++++++ > include/linux/of_pci.h | 9 ++++ > 8 files changed, 183 insertions(+), 8 deletions(-) > create mode 100644 drivers/pci/pci-of.c I'm going to ignore this version till the discussion on the previous one is over. Thanks, Rafael
Powered by blists - more mailing lists