linux-kernel - Re: [PATCH 4/4] phy: usb: phy-brcm-usb-init: DRD mode can cause crash on startup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee6cca50-0077-6458-1ce0-d3860ffa654d@gmail.com>
Date:   Wed, 27 Dec 2017 17:25:14 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Al Cooper <alcooperx@...il.com>,
        Kishon Vijay Abraham I <kishon@...com>
Cc:     Al Cooper <al.cooper@...adcom.com>, linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH 4/4] phy: usb: phy-brcm-usb-init: DRD mode can cause crash
 on startup



On 12/27/2017 11:28 AM, Al Cooper wrote:
> From: Al Cooper <al.cooper@...adcom.com>
> 
> This is caused by a bug in the BDC core. When the BDC core comes
> out of reset and it's not selected, it gets a backup clock. When
> the BDC core is selected, it get's the main clock. If HOST mode
> is then selected the BDC core has the main clock shut off but
> the backup clock is not restored.
> 
> The failure scenario and cause are as follows:
> - DRD mode is active
> - Device mode is selected first in bootloader
> - When host mode is now selected, the clock to the BDC is cut off.
> - BDC registers are inaccessible and therefore the BDC driver
>   crashes upon Linux boot.
> 
> The fix is to have the phy driver always force a BDC reset on
> startup.
> 
> Fixes: 49859e55e364 ("phy: usb: phy-brcm-usb: Add Broadcom STB USB phy driver")
> Signed-off-by: Al Cooper <alcooperx@...il.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian