linux-kernel - Re: [PATCH v2] x86/platform/intel-mid: Revert "Make 'bt_sfi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171228123413.3shmkfsewmq3y4e5@gmail.com>
Date:   Thu, 28 Dec 2017 13:34:14 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
        Darren Hart <dvhart@...radead.org>,
        platform-driver-x86@...r.kernel.org,
        Bhumika Goyal <bhumirks@...il.com>, julia.lawall@...6.fr
Subject: Re: [PATCH v2] x86/platform/intel-mid: Revert "Make 'bt_sfi_data'
 const"

* Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> v2: low the tone of accusation that this made a regression

BTW., don't worry about that aspect too much: after a long debugging session it's 
pretty natural to be upset at whoever introduced a regression.

( In fact a number of times I too got upset at the moron who wrote a particular 
  piece of buggy code, only for 'git annotate' to remind me that the moron was me. )

I personally just ignore the emotional attributes, and I usually edit changelogs 
accordingly as well so the temporary state of mind of finding a regression doesn't 
trickle upstream.

Plus in this particular case if we can help type propagation for driver data to 
become a bit cleaner then the kernel project has gained a bit through all this 
pain.

Thanks,

	Ingo