lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20171228135720.GL18255@piout.net> Date: Thu, 28 Dec 2017 14:57:20 +0100 From: Alexandre Belloni <alexandre.belloni@...e-electrons.com> To: Rob Herring <robh@...nel.org> Cc: Andreas Färber <afaerber@...e.de>, Philippe Ombredanne <pombredanne@...b.com>, Türk, Jan <Jan.Tuerk@...rion.de>, Mark Rutland <mark.rutland@....com>, Thierry Reding <thierry.reding@...il.com>, David Airlie <airlied@...ux.ie>, Russell King <linux@...linux.org.uk>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <kernel@...gutronix.de>, Fabio Estevam <fabio.estevam@....com>, Kevin Hilman <khilman@...libre.com>, Maxime Ripard <maxime.ripard@...e-electrons.com>, SZ Lin <sz.lin@...a.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, LinuxArmKernelMailingListe <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series On 26/12/2017 at 11:16:34 -0600, Rob Herring wrote: > On Fri, Dec 22, 2017 at 4:56 AM, Alexandre Belloni > <alexandre.belloni@...e-electrons.com> wrote: > > + Philippe > > > > On 22/12/2017 at 11:43:33 +0100, Andreas Färber wrote: > >> >> I'll change it for v3 of this patch however it will end up like this: > >> >> //SPDX-License... > >> > > >> > That should be /* SPDX-License */, // is for c files. > >> > >> Got any reference for that? Since we're using the C preprocessor before > >> feeding them to dtc, we can use the same // style for both, builds fine. > >> > >> Only for my private DT overlay files that I use directly with dtc I > >> couldn't adopt that style. > > We are well past the point of being able to build most dts files with just dtc. > > > The doc states: > > > > If a specific tool cannot handle the standard comment style, then the > > appropriate comment mechanism which the tool accepts shall be used. This > > is the reason for having the "/\* \*/" style comment in C header > > files. > > > > I interpreted that as dtc doesn't handle // comments, use /**/ > > It's been so long, I'd forgotten that. Perhaps we should fix dtc to > handle // comments. > The would probably be the best solution so we get a somewhat consistent style before people start moving the existing SDPX identifiers to the top of their dtsi/dts files. > > > > But I agree it also states: > > .dts{i}: // SPDX-License-Identifier: <SPDX License Expression> > > Or we could still change this. The guidelines aren't merged yet. > > Rob -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Powered by blists - more mailing lists