lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Dec 2017 16:59:12 +0000 From: Ben Hutchings <ben@...adent.org.uk> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org CC: akpm@...ux-foundation.org, "Michael S. Tsirkin" <mst@...hat.com>, "Matthew Rosato" <mjrosato@...ux.vnet.ibm.com>, Mark@...adent.org.uk, "David S. Miller" <davem@...emloft.net>, "Christian Borntraeger" <borntraeger@...ibm.com> Subject: [PATCH 3.2 67/94] macvtap: fix TUNSETSNDBUF values > 64k 3.2.97-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: "Michael S. Tsirkin" <mst@...hat.com> commit 3ea79249e81e5ed051f2e6480cbde896d99046e8 upstream. Upon TUNSETSNDBUF, macvtap reads the requested sndbuf size into a local variable u. commit 39ec7de7092b ("macvtap: fix uninitialized access on TUNSETIFF") changed its type to u16 (which is the right thing to do for all other macvtap ioctls), breaking all values > 64k. The value of TUNSETSNDBUF is actually a signed 32 bit integer, so the right thing to do is to read it into an int. Cc: David S. Miller <davem@...emloft.net> Fixes: 39ec7de7092b ("macvtap: fix uninitialized access on TUNSETIFF") Reported-by: Mark A. Peloquin Bisected-by: Matthew Rosato <mjrosato@...ux.vnet.ibm.com> Reported-by: Christian Borntraeger <borntraeger@...ibm.com> Signed-off-by: Michael S. Tsirkin <mst@...hat.com> Tested-by: Matthew Rosato <mjrosato@...ux.vnet.ibm.com> Acked-by: Christian Borntraeger <borntraeger@...ibm.com> Signed-off-by: David S. Miller <davem@...emloft.net> Signed-off-by: Ben Hutchings <ben@...adent.org.uk> --- drivers/net/macvtap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/net/macvtap.c +++ b/drivers/net/macvtap.c @@ -951,10 +951,10 @@ static long macvtap_ioctl(struct file *f return 0; case TUNSETSNDBUF: - if (get_user(u, up)) + if (get_user(s, sp)) return -EFAULT; - q->sk.sk_sndbuf = u; + q->sk.sk_sndbuf = s; return 0; case TUNGETVNETHDRSZ:
Powered by blists - more mailing lists