linux-kernel - Re: [PATCH 2/3] watchdog: Change ISA_BUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <839c0f58-408f-33c6-1438-236cd11adff0@roeck-us.net>
Date:   Thu, 28 Dec 2017 10:37:34 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     William Breathitt Gray <vilhelm.gray@...il.com>,
        linus.walleij@...aro.org
Cc:     mail@...iej.szmigiero.name, linux-gpio@...r.kernel.org,
        linux-iio@...r.kernel.org, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org, Wim Van Sebroeck <wim@...ana.be>
Subject: Re: [PATCH 2/3] watchdog: Change ISA_BUS_API dependency to selection

On 12/28/2017 08:02 AM, William Breathitt Gray wrote:
> The ISA_BUS_API Kconfig option enables the compilation of the ISA bus
> driver. The ISA bus driver does not perform any hardware interaction,
> and is instead just a thin layer of software abstraction to eliminate
> boilerplate code common to ISA-style device drivers. Since ISA_BUS_API
> has no dependencies and does not jeopardize the integrity of the system
> when enabled, drivers should select it when the ISA bus driver
> functionality is needed.
> 
> Cc: Wim Van Sebroeck <wim@...ana.be>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>

Acked-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/Kconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index ca200d1f310a..c05d5d20eebf 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -864,7 +864,8 @@ config ALIM7101_WDT
>   
>   config EBC_C384_WDT
>   	tristate "WinSystems EBC-C384 Watchdog Timer"
> -	depends on X86 && ISA_BUS_API
> +	depends on X86
> +	select ISA_BUS_API
>   	select WATCHDOG_CORE
>   	help
>   	  Enables watchdog timer support for the watchdog timer on the
>