lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <94dcaa45-70e0-09bf-ea14-e7cf764b0ee0@lab.ntt.co.jp> Date: Thu, 28 Dec 2017 09:59:58 +0900 From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp> To: Eric Leblond <eric@...it.org>, Alexei Starovoitov <alexei.starovoitov@...il.com> Cc: netdev@...r.kernel.org, daniel@...earbox.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/4] libbpf: add function to setup XDP On 2017/12/28 3:02, Eric Leblond wrote: > Most of the code is taken from set_link_xdp_fd() in bpf_load.c and > slightly modified to be library compliant. > > Signed-off-by: Eric Leblond <eric@...it.org> > --- ... > +int bpf_set_link_xdp_fd(int ifindex, int fd, __u32 flags) ... > + if (bind(sock, (struct sockaddr *)&sa, sizeof(sa)) < 0) { > + ret = -errno; > + goto cleanup; > + } > + > + addrlen = sizeof(sa); > + if (getsockname(sock, (struct sockaddr *)&sa, &addrlen) < 0) { > + ret = errno; forgot to prepend '-'? > + goto cleanup; > + } > + > + if (addrlen != sizeof(sa)) { > + ret = errno; errno is not set? > + goto cleanup; > + } -- Toshiaki Makita
Powered by blists - more mailing lists