lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20171228072053.GA27336@lunn.ch> Date: Thu, 28 Dec 2017 08:20:53 +0100 From: Andrew Lunn <andrew@...n.ch> To: Antoine Tenart <antoine.tenart@...e-electrons.com> Cc: davem@...emloft.net, kishon@...com, jason@...edaemon.net, sebastian.hesselbarth@...il.com, gregory.clement@...e-electrons.com, linux@...linux.org.uk, mw@...ihalf.com, stefanc@...vell.com, ymarkman@...vell.com, thomas.petazzoni@...e-electrons.com, miquel.raynal@...e-electrons.com, nadavh@...vell.com, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum On Wed, Dec 27, 2017 at 11:14:41PM +0100, Antoine Tenart wrote: > This patch adds one more generic PHY mode to the phy_mode enum, to allow > configuring generic PHYs to the 2.5G SGMII mode by using the set_mode > callback. > > Signed-off-by: Antoine Tenart <antoine.tenart@...e-electrons.com> > --- > include/linux/phy/phy.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index 4f8423a948d5..70459a28f3a1 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -28,6 +28,7 @@ enum phy_mode { > PHY_MODE_USB_DEVICE, > PHY_MODE_USB_OTG, > PHY_MODE_SGMII, > + PHY_MODE_SGMII_2_5G, > PHY_MODE_10GKR, > PHY_MODE_UFS_HS_A, > PHY_MODE_UFS_HS_B, Hi Antoine There was a discussion maybe last month about adding 2.5G SGMII. I would prefer 2500SGMII. Putting the number first makes it uniform with the other defines, 1000BASEX, 25000BASEX, 10GKR. Andrew
Powered by blists - more mailing lists