linux-kernel - Re: [RFC PATCH 2/3] mm, migrate: remove reason argument from new_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171229113237.GA27077@dhcp22.suse.cz>
Date:   Fri, 29 Dec 2017 12:32:37 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Zi Yan <zi.yan@...rutgers.edu>
Cc:     linux-mm@...ck.org, Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
        "Kirill A. Shutemov" <kirill@...temov.name>,
        Vlastimil Babka <vbabka@...e.cz>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andrea Reale <ar@...ux.vnet.ibm.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 2/3] mm, migrate: remove reason argument from
 new_page_t

On Tue 26-12-17 21:12:38, Zi Yan wrote:
> On 8 Dec 2017, at 11:15, Michal Hocko wrote:
[...]
> > @@ -1622,7 +1608,6 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
> >  		}
> >  		chunk_node = NUMA_NO_NODE;
> >  	}
> > -	err = 0;
> 
> This line can be merged into Patch 1. Or did I miss anything?

Yes, I will move it there.

> >  out_flush:
> >  	/* Make sure we do not overwrite the existing error */
> >  	err1 = do_move_pages_to_node(mm, &pagelist, chunk_node);
> > diff --git a/mm/page_isolation.c b/mm/page_isolation.c
> > index 165ed8117bd1..53d801235e22 100644
> > --- a/mm/page_isolation.c
> > +++ b/mm/page_isolation.c
> > @@ -293,8 +293,7 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn,
> >  	return pfn < end_pfn ? -EBUSY : 0;
> >  }
> >
> > -struct page *alloc_migrate_target(struct page *page, unsigned long private,
> > -				  int **resultp)
> > +struct page *alloc_migrate_target(struct page *page, unsigned long private)
> >  {
> >  	return new_page_nodemask(page, numa_node_id(), &node_states[N_MEMORY]);
> >  }
> > -- 
> > 2.15.0
> 
> Everything else looks good to me.
> 
> Reviewed-by: Zi Yan <zi.yan@...rutgers.edu>

Thanks!
-- 
Michal Hocko
SUSE Labs