linux-kernel - Re: [PATCH 1/7] MIPS: Loongson64: cleanup all cs5536 files to use SPDX Identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 29 Dec 2017 13:40:26 +0100
From:   Philippe Ombredanne <pombredanne@...b.com>
To:     Jiaxun Yang <jiaxun.yang@...goat.com>
Cc:     Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <james.hogan@...s.com>,
        Huacai CHen <chenhc@...ote.com>,
        Linux MIPS <linux-mips@...ux-mips.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/7] MIPS: Loongson64: cleanup all cs5536 files to use
 SPDX Identifier

On Tue, Dec 26, 2017 at 2:23 PM, Jiaxun Yang <jiaxun.yang@...goat.com> wrote:
> To reduce unnecessary license text.

<snip>

> diff --git a/arch/mips/loongson64/common/cs5536/cs5536_acc.c b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> index ab4d6cc57384..ba0474bb4a3d 100644
> --- a/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> +++ b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

Please use  // comment in .c files as requested by Linus and discussed on list.
This is also documented in Thomas doc patches.
This applies to the whole patch set.

<snip>

> diff --git a/arch/mips/loongson64/common/cs5536/cs5536_isa.c b/arch/mips/loongson64/common/cs5536/cs5536_isa.c
> index 924be39e7733..c358c0755eff 100644
> --- a/arch/mips/loongson64/common/cs5536/cs5536_isa.c
> +++ b/arch/mips/loongson64/common/cs5536/cs5536_isa.c
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

And this is the correct comment style for .h files.

Thanks!

-- 
Cordially
Philippe Ombredanne