linux-kernel - Re: [PATCH 3/3] perf/core: Move inline keyword at the beginning of declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171229124955.w2fntu777rw4qp4v@gmail.com>
Date:   Fri, 29 Dec 2017 13:49:55 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 3/3] perf/core: Move inline keyword at the beginning of
 declaration


* Mathieu Malaterre <malat@...ian.org> wrote:

> Hi Ingo,
> 
> On Thu, Dec 28, 2017 at 1:15 PM, Ingo Molnar <mingo@...nel.org> wrote:
> >
> > * Mathieu Malaterre <malat@...ian.org> wrote:
> >
> >> Fix non-fatal warnings such as:
> >>
> >> kernel/events/ring_buffer.c:116:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
> >>  static int __always_inline
> >>  ^~~~~~
> >>
> >> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> >> ---
> >>  kernel/events/ring_buffer.c | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > Hm, never saw this warning before - is this a newly default GCC warning, or some
> > distro CFLAGS build that enables it?
> 
> Nope. Just compiling vanilla kernel with default options, defconfig
> was pmac32. I used W=1.

"W=1" is not a default build variant - it enables -Wall...

This absolutely needs to be spelled out in the changelog!

Thanks,

	Ingo