linux-kernel - Re: [PATCH] video: fbdev: atmel_lcdfb: fix display-timings lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <1971311.3PN1zRAlXO@amdc3058>
Date:   Fri, 29 Dec 2017 18:23:23 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, stable <stable@...r.kernel.org>,
        Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
Subject: Re: [PATCH] video: fbdev: atmel_lcdfb: fix display-timings lookup

On Monday, November 13, 2017 11:27:19 AM Johan Hovold wrote:
> Fix child-node lookup during probe, which ended up searching the whole
> device tree depth-first starting at the parent rather than just matching
> on its children.
> 
> To make things worse, the parent display node was also prematurely
> freed.
> 
> Note that the display and timings node references are never put after a
> successful dt-initialisation so the nodes would leak on later probe
> deferrals and on driver unbind.
> 
> Fixes: b985172b328a ("video: atmel_lcdfb: add device tree suport")
> Cc: stable <stable@...r.kernel.org>     # 3.13
> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>

Patch queued for 4.16, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics