linux-kernel - Re: [PATCH v2 6/7] iio: adc: ina2xx: Align timestamp with conversion ready flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171229174903.1b2f66b7@archlinux>
Date:   Fri, 29 Dec 2017 17:49:03 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Stefan Brüns <stefan.bruens@...h-aachen.de>
Cc:     <linux-iio@...r.kernel.org>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Maciej Purski <m.purski@...sung.com>,
        <linux-kernel@...r.kernel.org>, "Andrew F . Davis" <afd@...com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Hartmut Knaack <knaack.h@....de>
Subject: Re: [PATCH v2 6/7] iio: adc: ina2xx: Align timestamp with
 conversion ready flag

On Thu, 21 Dec 2017 19:31:37 +0100
Stefan Brüns <stefan.bruens@...h-aachen.de> wrote:

> As the timestamp is no longer (ab-)used to measure the function run time,
> it can be taken at the correct time, i.e. when the conversion has finished.
> 
> Signed-off-by: Stefan Brüns <stefan.bruens@...h-aachen.de>
Applied.

Thanks,

Jonathan

> ---
> 
> Changes in v2: None
> 
>  drivers/iio/adc/ina2xx-adc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c
> index 415e53b5c0a6..b7407ac91b59 100644
> --- a/drivers/iio/adc/ina2xx-adc.c
> +++ b/drivers/iio/adc/ina2xx-adc.c
> @@ -706,8 +706,6 @@ static int ina2xx_work_buffer(struct iio_dev *indio_dev)
>  	s64 time;
>  	unsigned int alert;
>  
> -	time = iio_get_time_ns(indio_dev);
> -
>  	/*
>  	 * Because the timer thread and the chip conversion clock
>  	 * are asynchronous, the period difference will eventually
> @@ -736,6 +734,8 @@ static int ina2xx_work_buffer(struct iio_dev *indio_dev)
>  
>  		} while (!alert);
>  
> +	time = iio_get_time_ns(indio_dev);
> +
>  	/*
>  	 * Single register reads: bulk_read will not work with ina226/219
>  	 * as there is no auto-increment of the register pointer.