linux-kernel - Re: [PATCH v2] iio: adc: max9611: fix module auto-loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 29 Dec 2017 17:54:48 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Dmitry Mastykin <mastichi@...il.com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Rob Herring <robh@...nel.org>, linux-iio@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] iio: adc: max9611: fix module auto-loading

On Fri, 29 Dec 2017 17:30:39 +0200
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Fri, Dec 29, 2017 at 3:59 PM, Dmitry Mastykin <mastichi@...il.com> wrote:
> > The simplest fix is to move to ->probe_new() since the driver is not
> > used out of DT/ACPI enumeration.
> >  
> 
> Suggested-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 
> I suppose, and
> 
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
I'm a little confused.  Why does this now make module autoloading
work where it previously didn't?

Jonathan

> 
> Thanks!
> 
> > Signed-off-by: Dmitry Mastykin <mastichi@...il.com>
> > ---
> >  drivers/iio/adc/max9611.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c
> > index b1dd17c..ce0115a 100644
> > --- a/drivers/iio/adc/max9611.c
> > +++ b/drivers/iio/adc/max9611.c
> > @@ -523,8 +523,7 @@ static const struct of_device_id max9611_of_table[] = {
> >  };
> >
> >  MODULE_DEVICE_TABLE(of, max9611_of_table);
> > -static int max9611_probe(struct i2c_client *client,
> > -                        const struct i2c_device_id *id)
> > +static int max9611_probe(struct i2c_client *client)
> >  {
> >         const char * const shunt_res_prop = "shunt-resistor-micro-ohms";
> >         const struct device_node *of_node = client->dev.of_node;
> > @@ -576,7 +575,7 @@ static struct i2c_driver max9611_driver = {
> >                    .owner = THIS_MODULE,
> >                    .of_match_table = max9611_of_table,
> >         },
> > -       .probe = max9611_probe,
> > +       .probe_new = max9611_probe,
> >  };
> >  module_i2c_driver(max9611_driver);
> >
> > --
> > 2.7.4
> >  
> 
> 
>