linux-kernel - Re: [RFC PATCH v12 1/5] dt-bindings: PCI: Add definition of PCIe WAKE# irq and PCI irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171229175717.GL3875@atomide.com>
Date:   Fri, 29 Dec 2017 09:57:17 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     Jeffy Chen <jeffy.chen@...k-chips.com>
Cc:     linux-kernel@...r.kernel.org, bhelgaas@...gle.com,
        linux-pm@...r.kernel.org, shawn.lin@...k-chips.com,
        briannorris@...omium.org, rjw@...ysocki.net, dianders@...omium.org,
        devicetree@...r.kernel.org, linux-pci@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [RFC PATCH v12 1/5] dt-bindings: PCI: Add definition of PCIe
 WAKE# irq and PCI irq

* Jeffy Chen <jeffy.chen@...k-chips.com> [171226 02:11]:
> We are going to handle PCIe WAKE# pin for PCI devices in the pci core,
> so add definitions of the optional PCIe WAKE# pin for PCI devices.
> 
> Also add an definition of the optional PCI interrupt pin for PCI
> devices to distinguish it from the PCIe WAKE# pin.

> --- a/Documentation/devicetree/bindings/pci/pci.txt
> +++ b/Documentation/devicetree/bindings/pci/pci.txt
> @@ -24,3 +24,13 @@ driver implementation may support the following properties:
>     unsupported link speed, for instance, trying to do training for
>     unsupported link speed, etc.  Must be '4' for gen4, '3' for gen3, '2'
>     for gen2, and '1' for gen1. Any other values are invalid.
> +
> +PCI devices may support the following properties:

This should say PCI ports instead of PCI devices.

> +- interrupts: Interrupt specifier for each name in interrupt-names.
> +- interrupt-names:
> +    May contain "wakeup" for PCIe WAKE# interrupt and "pci" for PCI interrupt.
> +    The PCI devices may optionally include an 'interrupts' property that
> +    represents the legacy PCI interrupt. And when we try to specify the PCIe
> +    WAKE# pin, a corresponding 'interrupt-names' property is required to
> +    distinguish them.
> -- 
> 2.11.0
> 
>