linux-kernel - Re: [0/5] video-SMSC UFX: Adjustments for five function implementations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <265c7022-d12f-bcbe-c6f0-452ba3f73744@users.sourceforge.net>
Date:   Fri, 29 Dec 2017 19:43:00 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org
Cc:     Steve Glendinning <steve.glendinning@...well.net>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [0/5] video-SMSC UFX: Adjustments for five function
 implementations

>>   Delete an error message for a failed memory allocation in two functions
> 
> This patch removes the information about the device for which the allocation fails.

Should a Linux allocation failure report be sufficient here?


>>   Less checks in ufx_usb_probe() after error detection
> 
> This patch depends on the earlier patch (which is not being merged)

Partly, yes.


> so please re-base it if you want it to be applied.

Would you dare to pick another change possibility up from a patch hunk?


>>   Adjust three checks for null pointers
> 
> This patch contains unrelated change ({} braces addition) which should be dropped.

I presented such an update approach so that warnings from the script “checkpatch.pl”
will be fixed together.

Regards,
Markus