linux-kernel - Re: [PATCH] arch/x86/boot: sizeof macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9561caf7-0a7d-3bc1-fc26-fff74707032c@gmail.com>
Date:   Fri, 29 Dec 2017 20:34:47 +0100
From:   hacku <cpu808694@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arch/x86/boot: sizeof macro

Coding style for sizeof . If you check this file with checkpatch.pl you 
will see warning on this line. Yes, sorry I didn't mark this change as a 
coding style issue.

best regards,
Saidgani.

On 12/29/2017 07:41 PM, Andy Shevchenko wrote:
> On Fri, Dec 29, 2017 at 8:30 PM, Saidgani Musaev <cpu808694@...il.com> wrote:
>
> No changelog, no explanation why...
> No SoB tag...
>
>> -       ireg.cx  = sizeof buf;
>> +       ireg.cx  = sizeof(buf);
> sizeof is operator, not a function.
> So, what are you trying to achieve?
>