linux-kernel - [PATCH] objtool: fix segfault when missing '.shstrtab' section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20171229224621.27742-1-contact@emersion.fr>
Date:   Fri, 29 Dec 2017 23:46:21 +0100
From:   emersion <contact@...rsion.fr>
To:     jpoimboe@...hat.com, linux-kernel@...r.kernel.org
Cc:     emersion <contact@...rsion.fr>
Subject: [PATCH] objtool: fix segfault when missing '.shstrtab' section

This segfault happens when an input file provided to 'objtool orc
generate' doesn't have a '.shstrtab' section (for instance, object
files produced by clang don't have this section).

Signed-off-by: Simon Ser <contact@...rsion.fr>
---
 tools/objtool/orc_gen.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/objtool/orc_gen.c b/tools/objtool/orc_gen.c
index e5ca31429..188f18185 100644
--- a/tools/objtool/orc_gen.c
+++ b/tools/objtool/orc_gen.c
@@ -165,7 +165,8 @@ int create_orc_sections(struct objtool_file *file)
 
 	/* create .orc_unwind_ip and .rela.orc_unwind_ip sections */
 	sec = elf_create_section(file->elf, ".orc_unwind_ip", sizeof(int), idx);
-
+	if (!sec)
+		return -1;
 	ip_relasec = elf_create_rela_section(file->elf, sec);
 	if (!ip_relasec)
 		return -1;
-- 
2.15.1