linux-kernel - [PATCH] scsi: fnic: Use eth_broadcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 30 Dec 2017 21:28:31 +0530
From:   Himanshu Jha <himanshujha199640@...il.com>
To:     jejb@...ux.vnet.ibm.com, martin.petersen@...cle.com
Cc:     satishkh@...co.com, sebaddel@...co.com, kartilak@...co.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        mcgrof@...nel.org, Himanshu Jha <himanshujha199640@...il.com>
Subject: [PATCH] scsi: fnic: Use eth_broadcast_addr instead of memset

Use eth_broadcasr_addr Networking API instead of memset to assign the
broadcast address to the given address array.

0-day tested with no failures.

Signed-off-by: Himanshu Jha <himanshujha199640@...il.com>
---
 drivers/scsi/fnic/fnic_scsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
index 242e2ee..e51dc72 100644
--- a/drivers/scsi/fnic/fnic_scsi.c
+++ b/drivers/scsi/fnic/fnic_scsi.c
@@ -276,7 +276,7 @@ int fnic_flogi_reg_handler(struct fnic *fnic, u32 fc_id)
 	}
 
 	if (fnic->ctlr.map_dest) {
-		memset(gw_mac, 0xff, ETH_ALEN);
+		eth_broadcast_addr(gw_mac);
 		format = FCPIO_FLOGI_REG_DEF_DEST;
 	} else {
 		memcpy(gw_mac, fnic->ctlr.dest_addr, ETH_ALEN);
-- 
2.7.4