linux-kernel - Re: [RESEND, 2/4] i2c: mpc: unify obtaining the MPC8533/44 I2C clock prescaler w/ MPC8xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171230181920.4fmxcrvvcdf72u3q@ninjato>
Date:   Sat, 30 Dec 2017 19:19:20 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Arseny Solokha <asolokha@...kras.ru>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        Valentin Longchamp <valentin.longchamp@...mile.com>
Subject: Re: [RESEND, 2/4] i2c: mpc: unify obtaining the MPC8533/44 I2C clock
 prescaler w/ MPC8xxx

On Thu, Dec 07, 2017 at 05:20:01PM +0700, Arseny Solokha wrote:
> Commit 8ce795cb0c6b ("i2c: mpc: assign the correct prescaler from SVR")
> introduced the common helper function for obtaining the actual clock
> prescaler value for MPC85xx. However, getting the prescaler for MPC8544
> which depends on the SEC frequency ratio on this platform, has been always
> performed separately based on the corresponding Device Tree configuration.
> 
> Move special handling of MPC8544 into that common helper. Make it dependent
> on the SoC version and not on Device Tree compatible node, as is the case
> with all other SoCs. Handle MPC8533 the same way which is similar
> to MPC8544 in this regard, according to AN2919 "Determining the I2C
> Frequency Divider Ratio for SCL".
> 
> Signed-off-by: Arseny Solokha <asolokha@...kras.ru>

Looks good to me, but I have comments to patches 3+4.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)