linux-kernel - Re: [PATCH] crypto: Use zeroing memory allocator instead of allocator/memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171231164623.GA2709@himanshu-Vostro-3559>
Date:   Sun, 31 Dec 2017 22:16:23 +0530
From:   Himanshu Jha <himanshujha199640@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     herbert@...dor.apana.org.au, davem@...emloft.net,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        julia.lawall@...6.fr
Subject: Re: [PATCH] crypto: Use zeroing memory allocator instead of
 allocator/memset

On Sun, Dec 31, 2017 at 07:46:09AM -0800, Joe Perches wrote:
> On Sun, 2017-12-31 at 17:54 +0530, Himanshu Jha wrote:
> > Use dma_zalloc_coherent for allocating zeroed
> > memory and remove unnecessary memset function.
> > 
> > Done using Coccinelle.
> > Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
> 
> I thought you were going to change this tag to
> not use the "-by:" form and use something else
> like "generated-using:" or "created-with:".

Thanks for pointing that out!

I was going to ask this to Julia for the appropriate tag, but it slipped
my mind. In future I will definitely choose more appropriate tag
on the Coccinelle patches.

Just to give an insight of the problem to everyone :

While running checkpatch on patches involving the above Generated-by
tag, which is generally used to specify the cocci script used,
checkpatch prompts the below warning and error :

WARNING: Non-standard signature: Generated-by:
#10:
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci

ERROR: Unrecognized email address:
'scripts/coccinelle/api/alloc/kzalloc-simple.cocci'

Joe suggested to not use the "-by:" form since it should be reserved
for actual people's names and email addresses.
And if you use other tag than the "-by:" tag, then there is no
error/warning produced.

Thanks
Himanshu Jha