[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOFm3uE7wvk_9MuesAnSzW3JznwU4sbEU-vjW7JARrrKLPdQJw@mail.gmail.com>
Date: Sun, 31 Dec 2017 12:20:25 +0100
From: Philippe Ombredanne <pombredanne@...b.com>
To: Eric Leblond <eric@...it.org>
Cc: daniel@...earbox.net,
Toshiaki Makita <makita.toshiaki@....ntt.co.jp>,
Alexei Starovoitov <alexei.starovoitov@...il.com>,
netdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH bpf-next v4 2/3] libbpf: add error reporting in XDP
On Sat, Dec 30, 2017 at 9:41 PM, Eric Leblond <eric@...it.org> wrote:
> Parse netlink ext attribute to get the error message returned by
> the card. Code is partially take from libnl.
>
> Signed-off-by: Eric Leblond <eric@...it.org>
> Acked-by: Alexei Starovoitov <ast@...nel.org>
<snip>
> --- /dev/null
> +++ b/tools/lib/bpf/nlattr.c
> @@ -0,0 +1,187 @@
> +// SPDX-License-Identifier: LGPL-2.1
> +
> +/*
> + * NETLINK Netlink attributes
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation version 2.1
> + * of the License.
> + *
> + * Copyright (c) 2003-2013 Thomas Graf <tgraf@...g.ch>
> + */
Do you think you could get an ack or signoff from the author
(i.e.Thomas Graf) to get a more streamlined thing such as this:
> +// SPDX-License-Identifier: LGPL-2.1
> +// NETLINK Netlink attributes
> +// Copyright (c) 2003-2013 Thomas Graf <tgraf@...g.ch>
--
Cordially
Philippe Ombredanne
Powered by blists - more mailing lists