linux-kernel - Re: [PATCH -next] tee: shm: make local function __tee_shm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHUa44HJjkP3vw=WMYh4N5swOVoMEktyEYthUUfGLE9tqVkoTw@mail.gmail.com>
Date:   Tue, 2 Jan 2018 08:46:30 +0100
From:   Jens Wiklander <jens.wiklander@...aro.org>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] tee: shm: make local function __tee_shm_alloc() static

On Tue, Jan 2, 2018 at 5:09 AM, Wei Yongjun <weiyongjun1@...wei.com> wrote:
> Fixes the following sparse warnings:
>
> drivers/tee/tee_shm.c:115:16: warning:
>  symbol '__tee_shm_alloc' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/tee/tee_shm.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c
> index 04e1b8b..13b4de1 100644
> --- a/drivers/tee/tee_shm.c
> +++ b/drivers/tee/tee_shm.c
> @@ -112,9 +112,9 @@ static int tee_shm_op_mmap(struct dma_buf *dmabuf, struct vm_area_struct *vma)
>         .mmap = tee_shm_op_mmap,
>  };
>
> -struct tee_shm *__tee_shm_alloc(struct tee_context *ctx,
> -                               struct tee_device *teedev,
> -                               size_t size, u32 flags)
> +static struct tee_shm *__tee_shm_alloc(struct tee_context *ctx,
> +                                      struct tee_device *teedev,
> +                                      size_t size, u32 flags)
>  {
>         struct tee_shm_pool_mgr *poolm = NULL;
>         struct tee_shm *shm;
>

Thanks, but I've already picked up the same patch from Colin King a
few days ago.

/Jens