linux-kernel - Re: [PATCH 2/2] MIPS: Remove a warning when PHYS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Jan 2018 09:31:28 +0000
From:   James Hogan <james.hogan@...s.com>
To:     Mathieu Malaterre <malat@...ian.org>
CC:     Ralf Baechle <ralf@...ux-mips.org>,
        Marcin Nowakowski <marcin.nowakowski@...s.com>,
        Miodrag Dinic <miodrag.dinic@...s.com>,
        Aleksandar Markovic <aleksandar.markovic@...s.com>,
        David Daney <david.daney@...ium.com>,
        <linux-mips@...ux-mips.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] MIPS: Remove a warning when PHYS_OFFSET is 0x0

On Tue, Dec 26, 2017 at 12:37:14PM +0100, Mathieu Malaterre wrote:
> Rewrite the comparison in `else if` statement, case where `min_low_pfn >
> ARCH_PFN_OFFSET` has already been checked in the first `if` statement:
> 
>   if (min_low_pfn > ARCH_PFN_OFFSET) {
> 
> Fix non-fatal warning:
> 
> arch/mips/kernel/setup.c: In function ‘bootmem_init’:
> arch/mips/kernel/setup.c:461:25: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
>   } else if (min_low_pfn < ARCH_PFN_OFFSET) {
>                          ^

What compiler version is that with out of interest? It isn't exactly new
code.

> 
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>

Reviewed-by: James Hogan <jhogan@...nel.org>

Cheers
James

> ---
>  arch/mips/kernel/setup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
> index f19d61224c71..073695ccc1aa 100644
> --- a/arch/mips/kernel/setup.c
> +++ b/arch/mips/kernel/setup.c
> @@ -458,7 +458,7 @@ static void __init bootmem_init(void)
>  		pr_info("Wasting %lu bytes for tracking %lu unused pages\n",
>  			(min_low_pfn - ARCH_PFN_OFFSET) * sizeof(struct page),
>  			min_low_pfn - ARCH_PFN_OFFSET);
> -	} else if (min_low_pfn < ARCH_PFN_OFFSET) {
> +	} else if (ARCH_PFN_OFFSET - min_low_pfn > 0UL) {
>  		pr_info("%lu free pages won't be used\n",
>  			ARCH_PFN_OFFSET - min_low_pfn);
>  	}
> -- 
> 2.11.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)