linux-kernel - Re: [PATCH 4.14 00/74] 4.14.10-stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 2 Jan 2018 10:17:40 +0000
From:   Milosz Wasilewski <milosz.wasilewski@...aro.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Naresh Kamboju <naresh.kamboju@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Shuah Khan <shuahkh@....samsung.com>, patches@...nelci.org,
        Ben Hutchings <ben.hutchings@...ethink.co.uk>,
        lkft-triage@...ts.linaro.org,
        linux- stable <stable@...r.kernel.org>,
        Tom Gall <tom.gall@...aro.org>
Subject: Re: [PATCH 4.14 00/74] 4.14.10-stable review

On 31 December 2017 at 10:15, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>>
>> I re-tested ldt_gdt_64 again locally and in testing LAB. The test
>> failed again so I think this is a regression. I did the bisection
>> which resulted in
>>
>> 2c8e9099aecec2baaac8d34c7b823493f2d0eeed is the first bad commit
>> commit 2c8e9099aecec2baaac8d34c7b823493f2d0eeed
>> Author: Thomas Gleixner <tglx@...utronix.de>
>> Date:   Thu Dec 14 12:27:31 2017 +0100
>>
>>     x86/ldt: Prevent LDT inheritance on exec
>>
>>     commit a4828f81037f491b2cc986595e3a969a6eeb2fb5 upstream.
>>
>> Reverting this commit makes he ldt_gdt_64 pass again. However it's
>> worth to mention that the test uses a pre-build version of kselftest
>> from 4.14 (sources here:
>> https://www.kernel.org/pub/linux/kernel/v4.x/linux-4.14.tar.xz). The
>> offending commit also changed tools/testing/selftests/x86/ldt_gdt.c. I
>> re-tested original build using this version of kselftests and the
>> ldt_gdt_64 passes (as expected). This makes me thinking whether using
>> the 'old' version of kselftests is a good idea.
>
> You should use the version with the fix, for the obvious reason as
> documented in the selftest change :)

I'll move all our stable builds to use kselftests from 4.14.10.

milosz