linux-kernel - Re: [PATCH] PM / wakeup: Drop redundant check from device_set_wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 2 Jan 2018 14:44:47 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Linux PM <linux-pm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PM / wakeup: Drop redundant check from device_set_wakeup_enable()

On 26 December 2017 at 01:50, Rafael J. Wysocki <rjw@...ysocki.net> wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> Since both device_wakeup_enable() and device_wakeup_disable() check
> if dev is not NULL and whether or not power.can_wakeup is set for it,
> device_set_wakeup_enable() doesn't have to do that, so drop that
> check from it.
>
> No intentional changes in functionality.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Reviewed-by: Ulf Hansson <ulf.hansson@...aro.org>

Kind regards
Uffe

> ---
>  drivers/base/power/wakeup.c |    3 ---
>  1 file changed, 3 deletions(-)
>
> Index: linux-pm/drivers/base/power/wakeup.c
> ===================================================================
> --- linux-pm.orig/drivers/base/power/wakeup.c
> +++ linux-pm/drivers/base/power/wakeup.c
> @@ -464,9 +464,6 @@ EXPORT_SYMBOL_GPL(device_init_wakeup);
>   */
>  int device_set_wakeup_enable(struct device *dev, bool enable)
>  {
> -       if (!dev || !dev->power.can_wakeup)
> -               return -EINVAL;
> -
>         return enable ? device_wakeup_enable(dev) : device_wakeup_disable(dev);
>  }
>  EXPORT_SYMBOL_GPL(device_set_wakeup_enable);
>