linux-kernel - Re: [PATCH v2 1/2] nvmem: add driver for JZ4780 efuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANc+2y7_Bx7APkD2pDEQUT9cJqXEUCPkDQuzO_GP1qENabnNeQ@mail.gmail.com>
Date:   Tue, 2 Jan 2018 21:47:53 +0530
From:   PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     Mathieu Malaterre <malat@...ian.org>,
        Marcin Nowakowski <marcin.nowakowski@...s.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Zubair.Kakakhel@...s.com, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        open list <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org, linux-mips@...ux-mips.org
Subject: Re: [PATCH v2 1/2] nvmem: add driver for JZ4780 efuse

Hi Srini,

On 2 January 2018 at 17:32, Srinivas Kandagatla
<srinivas.kandagatla@...aro.org> wrote:
>
>
> On 28/12/17 21:29, Mathieu Malaterre wrote:
>>
>> From: PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>
>>
>> This patch brings support for the JZ4780 efuse. Currently it only expose
>> a read only access to the entire 8K bits efuse memory.
>>
>> Tested-by: Mathieu Malaterre <malat@...ian.org>
>> Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>
>> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
>> ---
>
> Please split this patch, as you are mixing code, documentation, dts and
> MAINTAINER changes here.
>
> Without which patch can not be reviewed!!

Sure, will do it soon.

>
> Thanks,
> Srini
>
>>   .../ABI/testing/sysfs-driver-jz4780-efuse          |  16 ++
>
>
>>   .../bindings/nvmem/ingenic,jz4780-efuse.txt        |  17 ++
>>   MAINTAINERS                                        |   5 +
>>   arch/mips/boot/dts/ingenic/jz4780.dtsi             |  40 ++-
>>   drivers/nvmem/Kconfig                              |  10 +
>>   drivers/nvmem/Makefile                             |   2 +
>>   drivers/nvmem/jz4780-efuse.c                       | 305
>> +++++++++++++++++++++
>>   7 files changed, 383 insertions(+), 12 deletions(-)
>
> ...

Regards,
PrasannaKumar