linux-kernel - Re: [PATCH] ata: ahci_brcm: Avoid clobbering SATA_TOP_CTRL_BUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180102163843.GG3668920@devbig577.frc2.facebook.com>
Date:   Tue, 2 Jan 2018 08:38:43 -0800
From:   Tejun Heo <tj@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com, linux-ide@...r.kernel.org
Subject: Re: [PATCH] ata: ahci_brcm: Avoid clobbering SATA_TOP_CTRL_BUS_CTRL

On Fri, Dec 22, 2017 at 11:43:08AM -0800, Florian Fainelli wrote:
> We are doing a blind write to SATA_TOP_CTRL_BUS_CTRL to set the system
> endian, but in doing so, we are also overwriting other bits, such as the
> SATA_SCB_BURST_SIZE and SATA_FIFO_SIZE bits, which impact performance.
> Do a read/modify/write so we keep the default values.
> 
> While we are at it, we also greatly simplify the logic and just leave
> the NSP specific bit settings, instead of having a completely different
> sequence.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied to libata/for-4.16.

Thanks.

-- 
tejun