linux-kernel - Re: [PATCH] x86/Kconfig: remove stale comment for ARCH_HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jKdDT=b9VY_F1tSkh3NGRi7PzzjC4CyTG_n7Hg_LcLKuQ@mail.gmail.com>
Date:   Tue, 2 Jan 2018 10:06:55 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Ingo Molnar <mingo@...hat.com>, Eric Biggers <ebiggers3@...il.com>
Cc:     X86 ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
        Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH] x86/Kconfig: remove stale comment for ARCH_HAS_REFCOUNT

On Fri, Dec 29, 2017 at 11:53 AM, Eric Biggers <ebiggers3@...il.com> wrote:
> From: Eric Biggers <ebiggers@...gle.com>
>
> ARCH_HAS_REFCOUNT is no longer marked as broken ('if BROKEN'), so remove
> the stale comment regarding it being broken.
>
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
>  arch/x86/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index d4fc98c50378..ff4e9cd99854 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -55,7 +55,6 @@ config X86
>         select ARCH_HAS_GCOV_PROFILE_ALL
>         select ARCH_HAS_KCOV                    if X86_64
>         select ARCH_HAS_PMEM_API                if X86_64
> -       # Causing hangs/crashes, see the commit that added this change for details.
>         select ARCH_HAS_REFCOUNT
>         select ARCH_HAS_UACCESS_FLUSHCACHE      if X86_64
>         select ARCH_HAS_SET_MEMORY
> --
> 2.15.1
>

Thanks for the catch!

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

-- 
Kees Cook
Pixel Security