linux-kernel - Re: [PATCH v2 02/21] nvmem: Introduce devm_nvmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHQ1cqGTophCKYsf=c_YECwBt8tQRhpT0wfvQwVxj+YyJO49xg@mail.gmail.com>
Date:   Tue, 2 Jan 2018 10:40:57 -0800
From:   Andrey Smirnov <andrew.smirnov@...il.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     Heiko Stuebner <heiko@...ech.de>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Carlo Caione <carlo@...one.org>,
        Kevin Hilman <khilman@...libre.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Chris Healy <cphealy@...il.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-mediatek@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 02/21] nvmem: Introduce devm_nvmem_(un)register()

On Tue, Jan 2, 2018 at 3:44 AM, Srinivas Kandagatla
<srinivas.kandagatla@...aro.org> wrote:
> Thanks for the patch,
>
> On 01/01/18 23:22, Andrey Smirnov wrote:
>>
>> Introduce devm_nvmem_register()/devm_nvmem_unregister() to make
>> .remove() unnecessary in trivial drivers.
>>
>> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>> Cc: Heiko Stuebner <heiko@...ech.de>
>> Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
>> Cc: Carlo Caione <carlo@...one.org>
>> Cc: Kevin Hilman <khilman@...libre.com>
>> Cc: Matthias Brugger <matthias.bgg@...il.com>
>> Cc: cphealy@...il.com
>> Cc: linux-kernel@...r.kernel.org
>> Cc: linux-mediatek@...ts.infradead.org
>> Cc: linux-rockchip@...ts.infradead.org
>> Cc: linux-amlogic@...ts.infradead.org
>> Cc: linux-arm-kernel@...ts.infradead.org
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
>> ---
>>   drivers/nvmem/core.c           | 41
>> +++++++++++++++++++++++++++++++++++++++++
>>   include/linux/nvmem-provider.h | 17 +++++++++++++++++
>>   2 files changed, 58 insertions(+)
>>
> Patch looks good, kernel doc for these exported symbols are missing, you
> should add them in next version!
>

Good point! Will do in v3.

Thanks,
Andrey Smirnov