| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <a77dc39a-cc5f-f41f-d4bc-7230820a9f9b@linux.intel.com>
Date: Tue, 2 Jan 2018 14:00:52 -0600
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To: Wei Yongjun <weiyongjun1@...wei.com>,
Vinod Koul <vinod.koul@...el.com>,
Sanyog Kale <sanyog.r.kale@...el.com>
Cc: alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH -next] soundwire: Fix typo in return value
check of sdw_read()
On 1/1/18 10:08 PM, Wei Yongjun wrote:
> Fix the typo, 'status' should be instead of 'status2'.
well spotted, thanks!
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
>
> Fixes: b0a9c37b0178 ("soundwire: Add slave status handling")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
> drivers/soundwire/bus.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
> index 4c34519..266d2b3 100644
> --- a/drivers/soundwire/bus.c
> +++ b/drivers/soundwire/bus.c
> @@ -671,8 +671,8 @@ static int sdw_handle_dp0_interrupt(struct sdw_slave *slave, u8 *slave_status)
> status2 = sdw_read(slave, SDW_DP0_INT);
> if (status2 < 0) {
> dev_err(slave->bus->dev,
> - "SDW_DP0_INT read failed:%d", status);
> - return status;
> + "SDW_DP0_INT read failed:%d", status2);
> + return status2;
> }
> status &= status2;
>
> @@ -741,10 +741,10 @@ static int sdw_handle_port_interrupt(struct sdw_slave *slave,
>
> /* Read DPN interrupt again */
> status2 = sdw_read(slave, addr);
> - if (status < 0) {
> + if (status2 < 0) {
> dev_err(slave->bus->dev,
> - "SDW_DPN_INT read failed:%d", status);
> - return status;
> + "SDW_DPN_INT read failed:%d", status2);
> + return status2;
> }
> status &= status2;
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
Powered by blists - more mailing lists