linux-kernel - Re: [PATCH v5] x86/microcode/intel: Blacklist the specific BDW-EP for late loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Jan 2018 04:49:42 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jia Zhang <qianyue.zj@...baba-inc.com>
Cc:     kbuild-all@...org, bp@...en8.de, mingo@...hat.com, hpa@...or.com,
        tglx@...utronix.de, tony.luck@...el.com, x86@...nel.org,
        linux-kernel@...r.kernel.org,
        Jia Zhang <qianyue.zj@...baba-inc.com>
Subject: Re: [PATCH v5] x86/microcode/intel: Blacklist the specific BDW-EP
 for late loading

Hi Jia,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v4.15-rc5]
[also build test ERROR on next-20180102]
[cannot apply to tip/x86/core]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jia-Zhang/x86-microcode-intel-Blacklist-the-specific-BDW-EP-for-late-loading/20180103-040752
config: i386-randconfig-x010-201800 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   arch/x86/kernel/cpu/microcode/intel.c: In function 'is_blacklisted':
>> arch/x86/kernel/cpu/microcode/intel.c:920:7: error: 'struct cpuinfo_x86' has no member named 'x86_stepping'
         c->x86_stepping == 0x01 && c->microcode < 0x0b000021) {
          ^~

vim +920 arch/x86/kernel/cpu/microcode/intel.c

   908	
   909	static bool is_blacklisted(unsigned int cpu)
   910	{
   911		struct cpuinfo_x86 *c = &cpu_data(cpu);
   912	
   913		/*
   914		 * The Broadwell-EP processor with the microcode version less
   915		 * then 0x0b000021 may result in system hang when running a late
   916		 * loading. This behavior is documented in item BDF90, #334165
   917		 * (Intel Xeon Processor E7-8800/4800 v4 Product Family).
   918		 */
   919		if (c->x86 == 6 && c->x86_model == INTEL_FAM6_BROADWELL_X &&
 > 920		    c->x86_stepping == 0x01 && c->microcode < 0x0b000021) {
   921			pr_err_once("Not loading old microcode version: erratum BDF90 on Intel Broadwell-EP stepping 1 CPUs may cause system hangs.\n");
   922			pr_err_once("Please update your microcode version through BIOS update or early loading from the initrd.\n");
   923		return true;
   924		}
   925	
   926		return false;
   927	}
   928	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (34256 bytes)