linux-kernel - RE: [LINUX PATCH 3/4] dmaengine: xilinx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Jan 2018 05:13:29 +0000
From:   Appana Durga Kedareswara Rao <appanad@...inx.com>
To:     Vinod Koul <vinod.koul@...el.com>
CC:     "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "michal.simek@...inx.com" <michal.simek@...inx.com>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "akinobu.mita@...il.com" <akinobu.mita@...il.com>,
        "joabreu@...opsys.com" <joabreu@...opsys.com>,
        "mike.looijmans@...ic.nl" <mike.looijmans@...ic.nl>,
        "kedare06@...il.com" <kedare06@...il.com>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [LINUX PATCH 3/4] dmaengine: xilinx_dma: Fix compilation warning

Hi Vinod,

	Thanks for the review... 

>
>On Thu, Dec 21, 2017 at 03:41:37PM +0530, Kedareswara rao Appana wrote:
>
>Fix title here too

Sure will fix in v2... 

>
>BTW whats with LINUX tag in patches, pls drop them

Ok will mention the Linux tag info in the cover letter patch from the next patch series on wards...

Regards,
Kedar.

>
>> This patch fixes the below sparse warning in the driver
>> drivers/dma/xilinx/xilinx_dma.c: In function
>‘xilinx_vdma_dma_prep_interleaved’:
>> drivers/dma/xilinx/xilinx_dma.c:1614:43: warning: variable ‘prev’ set but not
>used [-Wunused-but-set-variable]
>>   struct xilinx_vdma_tx_segment *segment, *prev = NULL;
>>
>> Signed-off-by: Kedareswara rao Appana <appanad@...inx.com>
>> ---
>>  drivers/dma/xilinx/xilinx_dma.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/dma/xilinx/xilinx_dma.c
>> b/drivers/dma/xilinx/xilinx_dma.c index 8467671..845e638 100644
>> --- a/drivers/dma/xilinx/xilinx_dma.c
>> +++ b/drivers/dma/xilinx/xilinx_dma.c
>> @@ -1611,7 +1611,7 @@ xilinx_vdma_dma_prep_interleaved(struct dma_chan
>> *dchan,  {
>>  	struct xilinx_dma_chan *chan = to_xilinx_chan(dchan);
>>  	struct xilinx_dma_tx_descriptor *desc;
>> -	struct xilinx_vdma_tx_segment *segment, *prev = NULL;
>> +	struct xilinx_vdma_tx_segment *segment;
>>  	struct xilinx_vdma_desc_hw *hw;
>>
>>  	if (!is_slave_direction(xt->dir))
>> @@ -1665,8 +1665,6 @@ xilinx_vdma_dma_prep_interleaved(struct dma_chan
>*dchan,
>>  	/* Insert the segment into the descriptor segments list. */
>>  	list_add_tail(&segment->node, &desc->segments);
>>
>> -	prev = segment;
>> -
>>  	/* Link the last hardware descriptor with the first. */
>>  	segment = list_first_entry(&desc->segments,
>>  				   struct xilinx_vdma_tx_segment, node);
>> --
>> 2.7.4
>>
>
>--
>~Vinod