linux-kernel - Re: [PATCH v3 18/27] pinctrl: replace devm_ioremap_nocache with devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <644fa45e-d06c-458b-464f-bd5312cc33b0@huawei.com>
Date:   Wed, 3 Jan 2018 14:15:36 +0800
From:   Yisheng Xie <xieyisheng1@...wei.com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Greg KH <gregkh@...uxfoundation.org>, <ysxie@...mail.com>,
        <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v3 18/27] pinctrl: replace devm_ioremap_nocache with
 devm_ioremap



On 2018/1/2 16:43, Linus Walleij wrote:
> On Sat, Dec 23, 2017 at 12:00 PM, Yisheng Xie <xieyisheng1@...wei.com> wrote:
> 
>> Default ioremap is ioremap_nocache, so devm_ioremap has the same
>> function with devm_ioremap_nocache, which can just be killed to
>> save the size of devres.o
>>
>> This patch is to use use devm_ioremap instead of devm_ioremap_nocache,
>> which should not have any function change but prepare for killing
>> devm_ioremap_nocache.
>>
>> Cc: Linus Walleij <linus.walleij@...aro.org>
>> Cc: linux-gpio@...r.kernel.org
>> Signed-off-by: Yisheng Xie <xieyisheng1@...wei.com>
> 
> Patch applied.

Well, I list the ARCHs related to the change file, do not include cris,ia64,mn10300
and openrisc, which ioremap is not the same as ioremap_nocache, as discussed in cover
letter. So please let me know if I need update the comment.

 change file							ARCH
 drivers/pinctrl/bcm/pinctrl-ns2-mux.c         | 2 +-		arm/arm64
 drivers/pinctrl/bcm/pinctrl-nsp-mux.c         | 4 ++--		arm
 drivers/pinctrl/freescale/pinctrl-imx1-core.c | 2 +-		arm
 drivers/pinctrl/pinctrl-amd.c                 | 4 ++--		x86/arm

Thanks
Yisheng
> 
> Yours,
> Linus Walleij
> 
>