linux-kernel - Re: [PATCH v3 06/27] gpio: replace devm_ioremap_nocache with devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdayoOOswWyi_1iBD4zpo99YZh_mPF_dYCvZbfSyv9hi5A@mail.gmail.com>
Date:   Wed, 3 Jan 2018 08:48:52 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Yisheng Xie <xieyisheng1@...wei.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Greg KH <gregkh@...uxfoundation.org>, ysxie@...mail.com,
        linux-gpio@...r.kernel.org
Subject: Re: [PATCH v3 06/27] gpio: replace devm_ioremap_nocache with devm_ioremap

On Wed, Jan 3, 2018 at 7:05 AM, Yisheng Xie <xieyisheng1@...wei.com> wrote:
> On 2018/1/2 16:41, Linus Walleij wrote:
>> On Sat, Dec 23, 2017 at 11:58 AM, Yisheng Xie <xieyisheng1@...wei.com> wrote:
>>
>>> Default ioremap is ioremap_nocache, so devm_ioremap has the same
>>> function with devm_ioremap_nocache, which can just be killed to
>>> save the size of devres.o
>>>
>>> This patch is to use use devm_ioremap instead of devm_ioremap_nocache,
>>> which should not have any function change but prepare for killing
>>> devm_ioremap_nocache.
>>>
>>> Cc: Linus Walleij <linus.walleij@...aro.org>
>>> Cc: linux-gpio@...r.kernel.org
>>> Signed-off-by: Yisheng Xie <xieyisheng1@...wei.com>
>
> Well, I list the ARCHs related to the change file, do not include cris,ia64,mn10300
> and openrisc, which ioremap is not the same as ioremap_nocache, as discussed in cover
> letter. So please let me know if I need update the comment.

I dropped the patch until it's figured out that none of these arches
are affected
by the change.

Please resend with a comment explaining why the change is harmless on the
architectures these drivers are for.

Yours,
Linus Walleij