linux-kernel - Re: [PATCH v17 0/5] ZII RAVE platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180103094621.su4umg2l5hggktlj@dell>
Date:   Wed, 3 Jan 2018 09:46:21 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Andrey Smirnov <andrew.smirnov@...il.com>,
        akpm@...ux-foundation.org, sfr@...b.auug.org.au
Cc:     Pavel Machek <pavel@....cz>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Chris Healy <cphealy@...il.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Johan Hovold <johan@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Sebastian Reichel <sebastian.reichel@...labora.co.uk>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v17 0/5] ZII RAVE platform driver

Well I guess we better at least include them in the conversation.

Stephen and Andrew added.

On Tue, 02 Jan 2018, Andrey Smirnov wrote:
> On Tue, Jan 2, 2018 at 7:17 AM, Lee Jones <lee.jones@...aro.org> wrote:
> > On Wed, 20 Dec 2017, Andrey Smirnov wrote:
> >
> >> Everyone:
> >>
> >> This patch series is v17 of the driver for supervisory processor found
> >> on RAVE series of devices from ZII. Supervisory processor is a PIC
> >> microcontroller connected to various electrical subsystems on RAVE
> >> devices whose firmware implements protocol to command/qery them.
> >>
> >> NOTE:
> >>
> >>  * This driver dependends on crc_ccitt_false(), added by
> >>    2da9378d531f8cc6670c7497f20d936b706ab80b in 'linux-next', the patch
> >>    was pulled in by Andrew Morton and is currently avaiting users, so
> >>    this series might have to go in through Andrew's tree
> >
> > Hmm... well that's annoying!  I just attempted to merge this set, but
> > early build tests fail due to a dependency already merged into -next.
> >
> > ../drivers/mfd/rave-sp.c:227:25: error:
> >     implicit declaration of function ‘crc_ccitt_false’
> >     [-Werror=implicit-function-declaration]
> >
> > We need to figure out if either of the following are true:
> >
> >  - Patch [0] can be dropped from Andrew's tree
> >    - ... and I can take it via the MFD tree instead

> FWIW, it seems to me that the path above should be doable (and might
> be simpler?). Let me know if any action needs to be taken on my part.
> 
> Thanks,
> Andrey Smirnov

> >  - Patch [0] is on an immutable branch I can pull in to my PR
> > 
> > If not, it will have to wait until the next cycle.
> > 
> > [0]:
> > 
> > Author: Andrey Vostrikov <andrey.vostrikov@...entembedded.com>
> > Date:   Mon Dec 25 22:39:57 2017 +1100
> > 
> >     lib/crc-ccitt: add CCITT-FALSE CRC16 variant
> > 
> >     In support of a soon to be published MFD driver using serdev to talk to
> >     a supervisory processor that uses the CCITT-FALSE CRC16 variant in it's
> >     protocol, this patch was tested successfully on an i.MX6 ARM platform.
> > 
> >     Link: http://lkml.kernel.org/r/20170413142932.27287-1-andrew.smirnov@gmail.com
> >     Signed-off-by: Andrey Vostrikov <andrey.vostrikov@...entembedded.com>
> >     Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> >     Tested-by: Chris Healy <cphealy@...il.com>
> >     Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> >     Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>

-- 
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog