linux-kernel - Re: [PATCH] i2c: fix ACPI_I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 3 Jan 2018 15:03:53 +0100
From:   Auger Eric <eric.auger@...hat.com>
To:     Sinan Kaya <okaya@...eaurora.org>,
        Randy Dunlap <rdunlap@...radead.org>, eric.auger.pro@...il.com,
        wsa@...-dreams.de, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH] i2c: fix ACPI_I2C_OPREGION dependency

Hi Sinan,
On 03/01/18 14:39, Sinan Kaya wrote:
> On 1/2/2018 1:19 PM, Sinan Kaya wrote:
>> On 1/2/2018 1:10 PM, Randy Dunlap wrote:
>>>>>  config ACPI_I2C_OPREGION
>>>>>  	bool "ACPI I2C Operation region support"
>>>>> -	depends on I2C=y && ACPI
>>>>> +	depends on I2C && ACPI
>>>>>  	default y
>>>>>  	help
>>>>>  	  Say Y here if you want to enable ACPI I2C operation region support.
>>>>>
>>>> Anybody picking this up?
>>> Well.  It looks to me like the patch is reversed or the patch description
>>> needs some improvement.  Or I just don't understand it.
>>
>> I'll let Eric improve the description. 
>>
>> Issue is that if you compile I2C as a module, ACPI_I2C_OPREGION doesn't get selected.
>> Therefore, any ACPI opregion calls targeting I2C fail with no opregion found.
>>
>> The goal is to select ACPI_I2C_OPREGION independent of the I2C module type selection.
>>
> 
> I hope I was able to explain it. =y above is the problem. This config option will only
> be selected if module is built-in not for m case.

Thank you for your input. I just sent a v2 with reworded commit message.
Hope this makes more sense.

Thanks

Eric
>